Open
Conversation
The asyncify pass handles Call and CallIndirect but not CallRef. This means call_ref instructions are not recognized as calls in ModuleAnalyzer, canChangeState(), or doesCall(), so they are never properly instrumented with asyncify's unwind/rewind support. Add visitCallRef handlers alongside the existing visitCallIndirect handlers in both walkers, and include CallRef in the doesCall() check. CallRef is treated the same as CallIndirect since both are indirect calls where the target may change state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CallandCallIndirectbut notCallRefin three critical locations:visitCallandvisitCallIndirectare handled;call_refinstructions don't propagatecanChangeState.canChangeState()Walker:CallRefis not visited, socall_refis treated as non-state-changing.doesCall(): Only checks forCallandCallIndirect, missingCallRef.call_refare not properly instrumented—thecall_refis wrapped withmakeMaybeSkipinstead of receiving full unwind/rewind support.AsyncifyUnwindWalker(for the unwind phase) already handlesCallRefcorrectly, confirming this is an oversight in the other locations.visitCallRefhandlers in both walkers and includedCallRefindoesCall(), treating it the same asCallIndirect.Test plan
test/lit/passes/asyncify-call-ref.wastverifying thatcall_refreceives proper asyncify instrumentation (unwind block, call index tracking, state checks).